disambiguate to location when no IPs can be determined#5486
Merged
Conversation
previously, fallback was to localhost, which could often be wrong.
Member
There was a problem hiding this comment.
location can be None if it's not passed - does it make sense for this function to return None?
Member
Author
There was a problem hiding this comment.
No, it should always return an IP. Note the if not location above.
Member
There was a problem hiding this comment.
Ah, OK. Then I think this looks OK.
takluyver
added a commit
that referenced
this pull request
Apr 21, 2014
disambiguate to location when no IPs can be determined
takluyver
added a commit
that referenced
this pull request
May 7, 2014
…ined previously, fallback was to localhost, which could often be wrong. closes #5477
takluyver
added a commit
that referenced
this pull request
May 7, 2014
…ined previously, fallback was to localhost, which could often be wrong. closes #5477
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
disambiguate to location when no IPs can be determined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, fallback was to localhost, which could often be wrong.
closes #5477